On 15 May 2018 at 15:41, Russell King - ARM Linux <li...@armlinux.org.uk> wrote: > On Tue, May 15, 2018 at 08:59:02AM +0200, Ulf Hansson wrote: >> On 8 May 2018 at 21:06, Kim Phillips <kim.phill...@arm.com> wrote: >> > This patch is provided in the context of allowing the Coresight driver >> > subsystem to be loaded as modules. Coresight uses amba_bus in its call >> > to bus_find_device() in of_coresight_get_endpoint_device() when >> > searching for a configurable endpoint device. This patch allows >> > Coresight to reference amba_bustype when built as a module. >> >> Sounds like you are fixing a bug, don't your want this to go for >> stable and then also add a fixes tag? > > What bug is this fixing exactly that would qualify it for stable > backporting?
That was my question, as when reading the changelog of $subject patch, this isn't clear to me. > > The lack of an export is never a bug unless there is some existing > user which requires it. This is not the case here. > > What Kim is doing in his new patch series is making Coresight - which > is currently only available as either disabled or built-in - possible > to be loaded as a module. This is a new feature, and in the process > of creating this new feature, Kim needs a symbol that wasn't previously > needed to be exported. Thanks for clarifying, I did not review the entire series. The change make perfect sense, no objections - and of course I agree it's not a bug fix. [...] Kind regards Uffe