On 05/16/2018 10:32 PM, Alexandre Belloni wrote:
> On 09/05/2018 17:46:10+0200, Amelie Delaunay wrote:
>>   struct stm32_rtc_registers {
>> @@ -86,6 +98,9 @@ struct stm32_rtc_registers {
>>      u8 prer;
>>      u8 alrmar;
>>      u8 wpr;
>> +    u8 sr;
>> +    u8 scr;
>> +    u16 verr;
> 
> All those offsets should probably be u16 or u32...
>

OK, those offsets will be all u16 in v3, the maximum STM32 RTC register 
offset value being 0x3FC.

>> +    if (regs.verr != UNDEF_REG) {
> 
> ...else, this is not working, as reported by kbuild
> 

Yes, in v3, UNDEF_REG will be the maximum u16 value (0xFFFF) instead of ~0.

>> +            u32 ver = readl_relaxed(rtc->base + regs.verr);
>> +
>> +            dev_info(&pdev->dev, "registered rev:%d.%d\n",
>> +                     (ver >> STM32_RTC_VERR_MAJREV_SHIFT) & 0xF,
>> +                     (ver >> STM32_RTC_VERR_MINREV_SHIFT) & 0xF);
>> +    }
>> +
> 

Thanks,
Amelie

Reply via email to