Hi, On Fri, May 11, 2018 at 6:46 PM, David Collins <colli...@codeaurora.org> wrote: > Add a common device tree property for regulator nodes to support > the specification of allowed operating modes. > > Signed-off-by: David Collins <colli...@codeaurora.org> > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt > b/Documentation/devicetree/bindings/regulator/regulator.txt > index 2babe15b..c627aa0 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -59,6 +59,11 @@ Optional properties: > - regulator-initial-mode: initial operating mode. The set of possible > operating > modes depends on the capabilities of every hardware so each device binding > documentation explains which values the regulator supports. > +- regulator-allowed-modes: list of operating modes that software is allowed > to > + configure for the regulator at run-time. Elements may be specified in any > + order. The set of possible operating modes depends on the capabilities of > + every hardware so each device binding document explains which values the > + regulator supports.
Looks sane to me. It might be interesting to be explicit about what happens if "regulator-allowed-modes" doesn't include the mode that was listed as "regulator-initial-mode". Does that mean that there's no way to get back to "regulator-initial-mode" after it's been changed once, or is it an error to not include the initial mode in the set of allowed modes? I'm not 100% sure if going to such detail is necessary though. Thus, feel free to add: Reviewed-by: Douglas Anderson <diand...@chromium.org>