On Fri, 25 May 2018 14:19:43 -0400 Steven Rostedt <[email protected]> wrote:
> On Fri, 25 May 2018 14:15:06 -0400 > Steven Rostedt <[email protected]> wrote: > > > diff --git > > a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > > > > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > > new file mode 100644 > > index 000000000000..447df015c56f > > --- /dev/null > > +++ > > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > > @@ -0,0 +1,68 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0 > > +# description: trace_marker trigger - test histogram with synthetic event > > +# flags: > > + > > I forgot to update the description. Here's the new patch: > > -- Steve > > From 9699fdb67ba8ea9981bd0af1802209b0011a86ab Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (VMware)" <[email protected]> > Date: Mon, 14 May 2018 15:47:07 -0400 > Subject: [PATCH] tracing/selftest: Add test to test hist trigger between > kernel event and trace_marker > > Add a test that tests a trigger that is initiated by a kernel event > (sched_waking) and compared to a write to the trace_marker. > Yeah, this looks good to me :) Acked-by: Masami Hiramatsu <[email protected]> Thanks! > Signed-off-by: Steven Rostedt (VMware) <[email protected]> > --- > .../trigger-trace-marker-synthetic-kernel.tc | 68 > ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > > diff --git > a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > new file mode 100644 > index 000000000000..0a69c5d1cda8 > --- /dev/null > +++ > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-synthetic-kernel.tc > @@ -0,0 +1,68 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: trace_marker trigger - test histogram with synthetic event > against kernel event > +# flags: > + > +do_reset() { > + reset_trigger > + echo > set_event > + echo > synthetic_events > + clear_trace > +} > + > +fail() { #msg > + do_reset > + echo $1 > + exit_fail > +} > + > +if [ ! -f set_event ]; then > + echo "event tracing is not supported" > + exit_unsupported > +fi > + > +if [ ! -f synthetic_events ]; then > + echo "synthetic events not supported" > + exit_unsupported > +fi > + > +if [ ! -d events/ftrace/print ]; then > + echo "event trace_marker is not supported" > + exit_unsupported > +fi > + > +if [ ! -d events/sched/sched_waking ]; then > + echo "event sched_waking is not supported" > + exit_unsupported > +fi > + > +if [ ! -f events/ftrace/print/trigger ]; then > + echo "event trigger is not supported" > + exit_unsupported > +fi > + > +if [ ! -f events/ftrace/print/hist ]; then > + echo "hist trigger is not supported" > + exit_unsupported > +fi > + > +do_reset > + > +echo "Test histogram kernel event to trace_marker latency histogram trigger" > + > +echo 'latency u64 lat' > synthetic_events > +echo 'hist:keys=pid:ts0=common_timestamp.usecs' > > events/sched/sched_waking/trigger > +echo > 'hist:keys=common_pid:lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_waking).latency($lat)' > > events/ftrace/print/trigger > +echo 'hist:keys=common_pid,lat:sort=lat' > events/synthetic/latency/trigger > +sleep 1 > +echo "hello" > trace_marker > + > +grep 'hitcount: *1$' events/ftrace/print/hist > /dev/null || \ > + fail "hist trigger did not trigger correct times on trace_marker" > + > +grep 'hitcount: *1$' events/synthetic/latency/hist > /dev/null || \ > + fail "hist trigger did not trigger " > + > +do_reset > + > +exit 0 > -- > 2.13.6 > -- Masami Hiramatsu <[email protected]>
