Hi, Andrey Anson Huang Best Regards!
> -----Original Message----- > From: Andrey Smirnov [mailto:[email protected]] > Sent: Wednesday, May 30, 2018 7:11 AM > To: Anson Huang <[email protected]> > Cc: Shawn Guo <[email protected]>; Sascha Hauer > <[email protected]>; Sascha Hauer <[email protected]>; Fabio > Estevam <[email protected]>; dl-linux-imx <[email protected]>; > linux-arm-kernel <[email protected]>; linux-kernel > <[email protected]> > Subject: Re: [PATCH] soc: imx: gpcv2: correct PGC offset > > On Tue, May 29, 2018 at 1:02 AM, Anson Huang <[email protected]> > wrote: > > Correct MIPI/PCIe/USB_HSIC's PGC offset based on design RTL, the value > > on Reference Manual are incorrect. > > > > Nit: I'd s/the value on/the values in the/ here. > > > The correct offset should be as below: > > > > 0x800 ~ 0x83F: PGC for core0 of A7 platform; > > 0x840 ~ 0x87F: PGC for core1 of A7 platform; > > 0x880 ~ 0x8BF: PGC for SCU of A7 platform; > > 0xA00 ~ 0xA3F: PGC for fastmix/megamix; > > 0xC00 ~ 0xC3F: PGC for MIPI PHY; > > 0xC40 ~ 0xC7F: PGC for PCIe_PHY; > > 0xC80 ~ 0xCBF: PGC for USB OTG1 PHY; > > 0xCC0 ~ 0xCFF: PGC for USB OTG2 PHY; > > 0xD00 ~ 0xD3F: PGC for USB HSIC PHY; > > > > Signed-off-by: Anson Huang <[email protected]> > > --- > > drivers/soc/imx/gpcv2.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index > > afc7ecc..132c946 100644 > > --- a/drivers/soc/imx/gpcv2.c > > +++ b/drivers/soc/imx/gpcv2.c > > @@ -40,9 +40,9 @@ > > #define GPC_M4_PU_PDN_FLG 0x1bc > > > > > > -#define PGC_MIPI 4 > > -#define PGC_PCIE 5 > > -#define PGC_USB_HSIC 8 > > +#define PGC_MIPI 16 > > +#define PGC_PCIE 17 > > +#define PGC_USB_HSIC 20 > > As a suggestion, please add a comment explicitly saying that those values > might differ from what some version of the RM might specify. > Explanation in commit message is great, but seeing a note in the code might > save quite a bit of digging for someone who is reading the code, double > checking those values and thinking that they might be wrong. > > Other than that: > > Acked-by: Andrey Smirnov <[email protected]> > > Thanks, > Andrey Smirnov Thanks, I will improve them in V2 patch. Anson.
