On Wed, Jun 6, 2018 at 10:18 PM, Joe Perches <[email protected]> wrote: > On Wed, 2018-06-06 at 14:15 -0600, Jason Gunthorpe wrote: >> The true option causes this indenting for functions: >> >> static struct something_very_very_long * >> function(void *arg) >> { >> >> While a quick survey suggests that the usual Linux fallback is the GNU >> style: >> >> static struct something_very_very_long * >> function(void *arg) >> > [] >> AFAIK the above describes the more common choice in the code base? >> >> Not sure who's tree this is supposed to go through.. Andrew I guess? > > I believe so yes. > > I expect there will be more refinements to .clang-formata > as perhaps more people experiment with it too.
Yes, indeed! The version I committed was an initial approximation -- don't expect it to be the "final" or "official" one! Cheers, Miguel > > Acked-by: Joe Perches <[email protected]> > >> diff --git a/.clang-format b/.clang-format >> index faffc0d5af4eeb..1d5da22e0ba50c 100644 >> --- a/.clang-format >> +++ b/.clang-format >> @@ -382,7 +382,7 @@ IncludeIsMainRegex: '(Test)?$' >> IndentCaseLabels: false >> #IndentPPDirectives: None # Unknown to clang-format-5.0 >> IndentWidth: 8 >> -IndentWrappedFunctionNames: true >> +IndentWrappedFunctionNames: false >> JavaScriptQuotes: Leave >> JavaScriptWrapImports: true >> KeepEmptyLinesAtTheStartOfBlocks: false
