3.16.57-rc1 review patch. If anyone has any objections, please let me know.
------------------ From: "Michael Kerrisk (man-pages)" <[email protected]> commit 3734a13b96ebf039b293d8d37a934fd1bd9e03ab upstream. This is a preparatory patch for following work. account_pipe_buffers() performs accounting in the 'user_struct'. There is no need to pass a pointer to a 'pipe_inode_info' struct (which is then dereferenced to obtain a pointer to the 'user' field). Instead, pass a pointer directly to the 'user_struct'. This change is needed in preparation for a subsequent patch that the fixes the limit checking in alloc_pipe_info() (and the resulting code is a little more logical). Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Michael Kerrisk <[email protected]> Reviewed-by: Vegard Nossum <[email protected]> Cc: Willy Tarreau <[email protected]> Cc: <[email protected]> Cc: Tetsuo Handa <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Al Viro <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Ben Hutchings <[email protected]> --- fs/pipe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/fs/pipe.c +++ b/fs/pipe.c @@ -590,10 +590,10 @@ pipe_fasync(int fd, struct file *filp, i return retval; } -static void account_pipe_buffers(struct pipe_inode_info *pipe, +static void account_pipe_buffers(struct user_struct *user, unsigned long old, unsigned long new) { - atomic_long_add(new - old, &pipe->user->pipe_bufs); + atomic_long_add(new - old, &user->pipe_bufs); } static bool too_many_pipe_buffers_soft(struct user_struct *user) @@ -628,7 +628,7 @@ struct pipe_inode_info *alloc_pipe_info( pipe->r_counter = pipe->w_counter = 1; pipe->buffers = pipe_bufs; pipe->user = user; - account_pipe_buffers(pipe, 0, pipe_bufs); + account_pipe_buffers(user, 0, pipe_bufs); mutex_init(&pipe->mutex); return pipe; } @@ -643,7 +643,7 @@ void free_pipe_info(struct pipe_inode_in { int i; - account_pipe_buffers(pipe, pipe->buffers, 0); + account_pipe_buffers(pipe->user, pipe->buffers, 0); free_uid(pipe->user); for (i = 0; i < pipe->buffers; i++) { struct pipe_buffer *buf = pipe->bufs + i; @@ -1062,7 +1062,7 @@ static long pipe_set_size(struct pipe_in memcpy(bufs + head, pipe->bufs, tail * sizeof(struct pipe_buffer)); } - account_pipe_buffers(pipe, pipe->buffers, nr_pages); + account_pipe_buffers(pipe->user, pipe->buffers, nr_pages); pipe->curbuf = 0; kfree(pipe->bufs); pipe->bufs = bufs;
