On Tue, Jun 5, 2018 at 11:32 PM Adrian Hunter <[email protected]> wrote: > > On 29/05/18 12:52, Vijay Viswanath wrote: > > In addition to offsets of certain registers changing, the registers in > > core_mem have been shifted to HC mem as well. To access these > > registers, define msm version specific functions. These functions can > > be loaded into the function pointers at the time of probe based on > > the msm version detected. > > > > Also defind new data structure to hold version specific Ops and > > register addresses. > > > > Signed-off-by: Sayali Lokhande <[email protected]> > > Signed-off-by: Vijay Viswanath <[email protected]> > > Acked-by: Adrian Hunter <[email protected]> > > > --- > > drivers/mmc/host/sdhci-msm.c | 77 > > ++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > > index 4050c99..2a66aa0 100644 > > --- a/drivers/mmc/host/sdhci-msm.c > > +++ b/drivers/mmc/host/sdhci-msm.c > > @@ -226,6 +226,24 @@ struct sdhci_msm_offset { > > .core_ddr_config_2 = 0x1bc, > > }; > > > > +struct sdhci_msm_variant_ops { > > + u8 (*msm_readb_relaxed)(struct sdhci_host *host, u32 offset); > > + u32 (*msm_readl_relaxed)(struct sdhci_host *host, u32 offset); > > + void (*msm_writeb_relaxed)(u8 val, struct sdhci_host *host, u32 > > offset); > > + void (*msm_writel_relaxed)(u32 val, struct sdhci_host *host, > > + u32 offset); > > +};
Since you removed the implementations, and these are also trivial to re-derive, I'd suggest removing msm_readb_relaxed and msm_writeb_relaxed members from the struct. Other than that, you can add my Reviewed-by. -Evan
