Make sure to use put_device() to free the initialised struct device so
that resources managed by driver core also gets released in the event of
a registration failure.

Fixes: de3910eb79ac ("edac: change the mem allocation scheme to make 
Documentation/kobject.txt happy")
Fixes: 2d56b109e3a5 ("EDAC: Handle error path in edac_mc_sysfs_init() properly")
Cc: stable <sta...@vger.kernel.org>     # 3.6
Cc: Denis Kirjanov <kirja...@gmail.com>
Cc: Mauro Carvalho Chehab <mche...@redhat.com>
Signed-off-by: Johan Hovold <jo...@kernel.org>
---
 drivers/edac/edac_mc_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index 7481955160a4..20374b8248f0 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -1075,14 +1075,14 @@ int __init edac_mc_sysfs_init(void)
 
        err = device_add(mci_pdev);
        if (err < 0)
-               goto out_dev_free;
+               goto out_put_device;
 
        edac_dbg(0, "device %s created\n", dev_name(mci_pdev));
 
        return 0;
 
- out_dev_free:
-       kfree(mci_pdev);
+ out_put_device:
+       put_device(mci_pdev);
  out:
        return err;
 }
-- 
2.17.1

Reply via email to