On Mon, Jun 25, 2018 at 04:31:28PM +0300, Sagi Grimberg wrote: > > > On 06/25/2018 10:08 AM, Johannes Thumshirn wrote: > > On Tue, Jun 19, 2018 at 05:09:27PM +0300, Sagi Grimberg wrote: > > > We are going to need it for traffic based keep alive to update > > > that we saw a completion to extend the kato. > > > > > > But I suggest you simply keep a ctrl reference in struct nvme_request > > > instead so you don't need to pass it to nvme_complete_req (that's what > > > I did for traffic based keep alive). > > > > Do you have a patch for this around? IIRC I started this (as Christoph > > also suggested it) but it turned out to be quite a big refactoring > > work. > > How about the below? patch #1 is what you are looking for, patch #2 is > a slightly modified version that applies on #1. Let me know what you > think...
Looks good (both #1 if we want to use the two patch version or #2). I have no idea what I did when I was trying to do when I tried it. Johannes -- Johannes Thumshirn Storage [email protected] +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
