Quoting Christian Brauner ([email protected]): > On Tue, Jun 26, 2018 at 04:06:45PM +0200, Jann Horn wrote: > > On Tue, Jun 26, 2018 at 3:08 PM Christian Brauner > > <[email protected]> wrote: > > > > > > On Mon, Jun 25, 2018 at 06:34:19PM +0200, Jann Horn wrote: > > > > The old code would hold the userns_state_mutex indefinitely if > > > > memdup_user_nul stalled due to e.g. a userfault region. Prevent that by > > > > moving the memdup_user_nul in front of the mutex_lock(). > > > > > > > > Note: This changes the error precedence of invalid buf/count/*ppos vs > > > > map already written / capabilities missing. > > > > > > > > Fixes: 22d917d80e84 ("userns: Rework the user_namespace adding > > > > uid/gid...") > > > > Cc: [email protected] > > > > Signed-off-by: Jann Horn <[email protected]> > > Acked-by: Christian Brauner <[email protected]>
Acked-by: Serge Hallyn <[email protected]> thanks. -serge
