On Sat, 30 Jun 2018 16:03:17 +0530 Vignesh R <[email protected]> wrote:
> Parent MFD device takes care of enabling ADC interface whenever > touchscreen is marked wakeup capable. Therefore, unconditionally disable > ADC interface during system suspend to save power in case of system with > just ADC and no TSC. > > Signed-off-by: Vignesh R <[email protected]> This sounds like a sensible change to me. Is it applicable without the rest of the series? If so I'll take it through IIO. If the answer is that it needs to go with the rest then Acked-by: Jonathan Cameron <[email protected]> Thanks, Jonathan > --- > drivers/iio/adc/ti_am335x_adc.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index 80df5a377d30..cafb1dcadc48 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -693,16 +693,12 @@ static int __maybe_unused tiadc_suspend(struct device > *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct tiadc_device *adc_dev = iio_priv(indio_dev); > - struct ti_tscadc_dev *tscadc_dev; > unsigned int idle; > > - tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev)); > - if (!device_may_wakeup(tscadc_dev->dev)) { > - idle = tiadc_readl(adc_dev, REG_CTRL); > - idle &= ~(CNTRLREG_TSCSSENB); > - tiadc_writel(adc_dev, REG_CTRL, (idle | > - CNTRLREG_POWERDOWN)); > - } > + idle = tiadc_readl(adc_dev, REG_CTRL); > + idle &= ~(CNTRLREG_TSCSSENB); > + tiadc_writel(adc_dev, REG_CTRL, (idle | > + CNTRLREG_POWERDOWN)); > > return 0; > }
