root@vm-lkp-nex04-8G-7 ~/linux-v4.18-rc2/tools/testing/selftests/android# make
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make 
rule.
make[1]: Entering directory 
'/root/linux-v4.18-rc2/tools/testing/selftests/android/ion'
gcc  -I. -I../../../../../drivers/staging/android/uapi/ 
-I../../../../../usr/include/ -Wall -O2 -g    ionapp_export.c ipcsocket.c 
ionutils.c   -o ionapp_export
ionapp_export.c: In function 'main':
ionapp_export.c:91:2: warning: 'heap_type' may be used uninitialized in
this function [-Wmaybe-uninitialized]
  printf("heap_type: %ld, heap_size: %ld\n", heap_type, heap_size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CC: Shuah Khan <sh...@kernel.org>
CC: Pintu Agarwal <pintu.p...@gmail.com>
Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com>
---
 tools/testing/selftests/android/ion/ionapp_export.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/testing/selftests/android/ion/ionapp_export.c 
b/tools/testing/selftests/android/ion/ionapp_export.c
index a944e72..e3435c2 100644
--- a/tools/testing/selftests/android/ion/ionapp_export.c
+++ b/tools/testing/selftests/android/ion/ionapp_export.c
@@ -49,6 +49,7 @@ int main(int argc, char *argv[])
                return -1;
        }
 
+       heap_type = -1UL;
        heap_size = 0;
        flags = 0;
 
@@ -82,6 +83,12 @@ int main(int argc, char *argv[])
                }
        }
 
+       if (heap_type == -1UL) {
+               printf("heap_type is invalid\n");
+               print_usage(argc, argv);
+               exit(1);
+       }
+
        if (heap_size <= 0) {
                printf("heap_size cannot be 0\n");
                print_usage(argc, argv);
-- 
2.7.4

Reply via email to