On Thu, 21 Jun 2018, Jae Hyun Yoo wrote: > This commit adds driver implementation for PECI bus core into linux > driver framework. > > Signed-off-by: Jae Hyun Yoo <[email protected]> > Signed-off-by: Fengguang Wu <[email protected]> > Reviewed-by: Haiyue Wang <[email protected]> > Reviewed-by: James Feist <[email protected]> > Reviewed-by: Vernon Mauery <[email protected]> > Cc: Alan Cox <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Andy Shevchenko <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Benjamin Herrenschmidt <[email protected]> > Cc: Fengguang Wu <[email protected]> > Cc: Greg KH <[email protected]> > Cc: Jason M Biils <[email protected]> > Cc: Julia Cartwright <[email protected]> > --- > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/peci/Kconfig | 12 + > drivers/peci/Makefile | 6 + > drivers/peci/peci-core.c | 1438 +++++++++++++++++++++++++++++++ > include/linux/peci.h | 104 +++ > include/uapi/linux/peci-ioctl.h | 265 ++++++ > 7 files changed, 1828 insertions(+) > create mode 100644 drivers/peci/Kconfig > create mode 100644 drivers/peci/Makefile > create mode 100644 drivers/peci/peci-core.c > create mode 100644 include/linux/peci.h > create mode 100644 include/uapi/linux/peci-ioctl.h
I'm struggling to see the justification for adding an entirely new subsystem for what looks like a bespoke, and perhaps more damning, *proprietary* 1-wire interface. Especially one which has such limited use. Between yourself and the other silicon chip vendors there must be 100s of these knocking about. What makes this one special? Or even useful? Will there ever be more than a single source file in this directory? Don't get me wrong, I'm all for upstreaming code, but to create a new subsystem and bus for this kind of device seems very over the top. Since PECI's main purpose in life is Thermal Management, perhaps the whole thing should live in drivers/thermal or drivers/hwmon. I've also seen you reference this as a kind of BMC too, so maybe drivers/platform/x86 would also be a nice place for it to reside. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
