On 2018/07/10 4:11, Josh Poimboeuf wrote: > On Mon, Jul 09, 2018 at 10:49:53AM +0200, Peter Zijlstra wrote: >> On Sat, Jul 07, 2018 at 10:54:28PM +0900, Tetsuo Handa wrote: >>>>> Since syzbot is confused by concurrent printk() messages [1], >>>>> this patch changes show_opcodes() to use snprintf(). >> >> But how big of a problem is that really? We can't very well remove all >> pr_cont stuff from the kernel. > > I'd say we should try to make oopses as legible as possible. > > Also KERN_CONT is inherently broken, and we should avoid using it in > general, IMO. >
We can't afford removing all pr_cont()/KERN_CONT. But show_opcodes() is an example of function which is expected to be SMP-safe. /* * Annotation for a "continued" line of log printout (only done after a * line that had no enclosing \n). Only to be used by core/arch code * during early bootup (a continued line is not SMP-safe otherwise). */ #define KERN_CONT KERN_SOH "c"
