On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > Hi Alexey, > > Good catch! > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > > pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() > > anywhere in the driver. > > > > The patch adds one to error handling code and to pxrc_disconnect(). > > > > Found by Linux Driver Verification project (linuxtesting.org). > > > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> > > Reviewed-by: Marcus Folkesson <marcus.folkes...@gmail.com>
Hmm, the biggest question however if we need to "take" the device, as I do not think interface can outlive the device, and whether we actually need to store it in pxrc, as we only need it during set up, as far as I can see. Thanks. -- Dmitry
