Hi Andreas,

On Sun, Jul 22, 2018 at 11:20:01PM +0200, Andreas Färber wrote:
> diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts 
> b/arch/mips/boot/dts/img/pistachio_marduk.dts
> index d723b68084c9..b0b6b534a41f 100644
> --- a/arch/mips/boot/dts/img/pistachio_marduk.dts
> +++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
> @@ -158,6 +158,20 @@
>                  <&gpio1 12 GPIO_ACTIVE_HIGH>,
>                  <&gpio1 13 GPIO_ACTIVE_HIGH>,
>                  <&gpio1 14 GPIO_ACTIVE_HIGH>;
> +
> +     ca8210: sixlowpan@4 {
> +             compatible = "cascoda,ca8210";
> +             reg = <4>;
> +             spi-max-frequency = <3000000>;
> +             spi-cpol;
> +             reset-gpio = <&gpio0 12 GPIO_ACTIVE_HIGH>;
> +             irq-gpio = <&gpio2 12 GPIO_ACTIVE_HIGH>;
> +
> +             extclock-enable;
> +             extclock-freq = <16000000>;
> +             extclock-gpio = <2>; /* spiuart_clk */
> +             #clock-cells = <0>;
> +     };

dtc complains about the extclock-gpio property because it expects a
property named *-gpio to contain a gpio-list:

    DTC     arch/mips/boot/dts/img/pistachio_marduk.dtb
  arch/mips/boot/dts/img/pistachio_marduk.dtb: Warning (gpios_property):
    /spi@18100f00/sixlowpan@4: Missing property '#gpio-cells' in node
    /clk@18144000 or bad phandle (referred from extclock-gpio[0])

Rob, perhaps this should be added as a second false-positive case in
dtc's prop_is_gpio()?

Thanks,
    Paul

Reply via email to