at 4:14 AM, Ingo Molnar <[email protected]> wrote: > > * Masahiro Yamada <[email protected]> wrote: > >> 2018-06-23 2:22 GMT+09:00 Nadav Amit <[email protected]>: >>> Using macros for inline assembly improves both readability and >>> compilation decisions that are distorted by big assembly blocks that use >>> alternative sections. Compile macros.S and use it to assemble all C >>> files. Currently, only x86 will use it. >>> >>> Cc: Sam Ravnborg <[email protected]> >>> Cc: Masahiro Yamada <[email protected]> >>> Cc: Michal Marek <[email protected]> >>> Cc: Thomas Gleixner <[email protected]> >>> Cc: Ingo Molnar <[email protected]> >>> Cc: "H. Peter Anvin" <[email protected]> >>> Cc: [email protected] >>> Cc: [email protected] >>> Acked-by: Peter Zijlstra (Intel) <[email protected]> >>> Signed-off-by: Nadav Amit <[email protected]> >>> --- >> >> >> >> Acked-by: Masahiro Yamada <[email protected]> >> >> >> >> >>> Makefile | 9 +++++++-- >>> arch/x86/Makefile | 11 +++++++++-- >>> arch/x86/kernel/macros.S | 7 +++++++ >>> scripts/Kbuild.include | 4 +++- >>> scripts/mod/Makefile | 2 ++ >>> 5 files changed, 28 insertions(+), 5 deletions(-) >>> create mode 100644 arch/x86/kernel/macros.S > > So this patch appears to break the xtensa cross-build on my system, with an > older > version of crosstools: > > MODPOST vmlinux.o > /home/mingo/crosstool-korg/bin//gcc-4.9.0-nolibc/xtensa-linux/bin/xtensa-linux-ld:./arch/xtensa/kernel/vmlinux.lds:430: > > syntax error > /home/mingo/tip/Makefile:1010: recipe for target 'vmlinux' failed > make[1]: *** [vmlinux] Error 1 > make[1]: Leaving directory '/dev/shm/tip/build' > Makefile:146: recipe for target 'sub-make’ failed
This one is due to a missing -DLINKER_SCRIPT in the Makefile of xtensa. I’ll send the patch to fix it after I deal with the boot failure (for which I wait for your config file). Thanks, Nadav
