On Montag, 9. Juli 2018 16:25:07 CEST Jiri Olsa wrote:
> On Tue, Jul 03, 2018 at 05:35:55PM +0530, Sandipan Das wrote:
>
> SNIP
>
> > After:
> > # perf report --stdio --no-children -s sym,srcline -g address
> >
> > # Samples: 1 of event 'probe_libc:inet_pton'
> > # Event count (approx.): 1
> > #
> > # Overhead Symbol Source:Line
> > # ........ .................... ...........
> > #
> >
> > 100.00% [.] __GI___inet_pton inet_pton.c
> >
> > ---gaih_inet.constprop.7 getaddrinfo.c:537
> >
> > getaddrinfo getaddrinfo.c:2304
> > main ping.c:519
> > generic_start_main.isra.0 libc-start.c:308
> > __libc_start_main libc-start.c:102
> >
> > ...
> >
> > # perf script -F comm,ip,sym,symoff,srcline,dso
> >
> > ping
> >
> > 7fffb38aaf28 __GI___inet_pton+0x8 (/usr/lib64/libc-2.26.so)
> >
> > inet_pton.c:68
> >
> > 7fffb385fa53 gaih_inet.constprop.7+0xf43
> > (/usr/lib64/libc-2.26.so)
> >
> > getaddrinfo.c:537
> >
> > 7fffb38605b3 getaddrinfo+0x163 (/usr/lib64/libc-2.26.so)
> >
> > getaddrinfo.c:2304
> >
> > 130782d6f main+0x3df (/usr/bin/ping)
> >
> > ping.c:519
> >
> > 7fffb377369f generic_start_main.isra.0+0x13f
> > (/usr/lib64/libc-2.26.so)
> >
> > libc-start.c:308
> >
> > 7fffb3773897 __libc_start_main+0xb7
> > (/usr/lib64/libc-2.26.so)
> >
> > libc-start.c:102
> >
> > Fixes: 67540759151a ("perf unwind: Use addr_location::addr instead of ip
> > for entries") Signed-off-by: Sandipan Das <sandi...@linux.ibm.com>
>
> looks good to me, Milian?
>
> Acked-by: Jiri Olsa <jo...@kernel.org>Sorry for the delay, I was on vacation. The above looks somewhat strange to me - why is there no `(inlined)` suffix visible anymore? Also, I can't test this patch locally, since - even without this patch - inline frame resolution with perf seems to be completely broken for me. It doesn't seem to be a perf regression - going back in time doesn't resole this - but rather of its dependencies or even of the DWARF emitted by the compilers I have available to test... Cheers -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt, C++ and OpenGL Experts
smime.p7s
Description: S/MIME cryptographic signature
