The current example for a thermal zone isn't very useful as reference
since it would result in a hardware shutdown at 145°C, instead of
allowing the system to try to shutdown gracefully. Without an ADC
channel a maximum of two trip points is useful in practice for this
sensor, with temperatures corresponding to the stage 1 and stage 2
'hardware trip points'. A critical trip point at stage 2 may allow the
system to shutdown before a hardware shutdown at stage 3 kicks in. It
should be noted though that by default the chip performs a 'partial
shutdown' when the temperature reaches stage 2, which may prevent an
orderly shutdown. The 'partial shutdown' can be disabled by software.

Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
Reviewed-by: Douglas Anderson <diand...@chromium.org>
---
Changes in v6:
- patch added to the series
---
 .../bindings/thermal/qcom-spmi-temp-alarm.txt         | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt 
b/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt
index 86fb41fe772f..0273a92a2a84 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt
+++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt
@@ -35,19 +35,14 @@ Example:
                        thermal-sensors = <&pm8941_temp>;
 
                        trips {
-                               passive {
-                                       temperature = <1050000>;
+                               stage1 {
+                                       temperature = <105000>;
                                        hysteresis = <2000>;
                                        type = "passive";
                                };
-                               alert {
+                               stage2 {
                                        temperature = <125000>;
                                        hysteresis = <2000>;
-                                       type = "hot";
-                               };
-                               crit {
-                                       temperature = <145000>;
-                                       hysteresis = <2000>;
                                        type = "critical";
                                };
                        };
-- 
2.18.0.345.g5c9ce644c3-goog

Reply via email to