Hi Dong Aisheng, On 07/26/2018 03:50 AM, A.s. Dong wrote: > Hi Stephen, > > Do you have a chance to look at it? > This patch series has been pending for quite a long time without much > comments. I'm not a kernel maintainer but I would not review a series that has checkpatch errors. Please run checkpatch, fix the errors and the warnings, and then resubmit a series.
Best Regards, Alexandre > > Regards > Dong Aisheng > >> -----Original Message----- >> From: A.s. Dong >> Sent: Wednesday, July 18, 2018 9:37 PM >> To: [email protected] >> Cc: [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; >> Anson Huang <[email protected]>; Jacky Bai <[email protected]>; dl- >> linux-imx <[email protected]>; A.s. Dong <[email protected]> >> Subject: [PATCH V4 0/9] clk: add imx7ulp clk support >> >> This is a rebased version of below patch series against latest clk tree. >> [PATCH RESEND V3 0/9] clk: add imx7ulp clk support >> https://lkml.org/lkml/2018/3/16/310 >> >> This patch series intends to add imx7ulp clk support. >> >> i.MX7ULP Clock functions are under joint control of the System Clock >> Generation (SCG) modules, Peripheral Clock Control (PCC) modules, and >> Core Mode Controller (CMC)1 blocks >> >> The clocking scheme provides clear separation between M4 domain and A7 >> domain. Except for a few clock sources shared between two domains, such >> as the System Oscillator clock, the Slow IRC (SIRC), and and the Fast IRC >> clock >> (FIRCLK), clock sources and clock management are separated and contained >> within each domain. >> >> M4 clock management consists of SCG0, PCC0, PCC1, and CMC0 modules. >> A7 clock management consists of SCG1, PCC2, PCC3, and CMC1 modules. >> >> Note: this series only adds A7 clock domain support as M4 clock domain will >> be handled by M4 seperately. >> >> Change Log: >> v3->v4: >> * rebased to latest kernel >> * make scg and pcc separate nodes according to Rob's suggestion >> >> v2->v3: >> * Patch 1 changed on: 1) split normal and gate ops 2) fix the possible racy >> Others no changes. >> >> v1->v2: >> * add enable/disable for the type of CLK_DIVIDER_ZERO_GATE dividers >> * use clk_hw apis to register clocks >> * use of_clk_add_hw_provider >> * split the clocks register process into two parts: early part for possible >> timers clocks registered by CLK_OF_DECLARE_DRIVER and the later part for >> the left normal peripheral clocks registered by a platform driver. >> >> Dong Aisheng (9): >> clk: clk-divider: add CLK_DIVIDER_ZERO_GATE clk support >> clk: fractional-divider: add CLK_FRAC_DIVIDER_ZERO_BASED flag support >> clk: imx: add pllv4 support >> clk: imx: add pfdv2 support >> clk: imx: add composite clk support >> dt-bindings: clock: add imx7ulp clock binding doc >> clk: imx: make mux parent strings const >> clk: imx: implement new clk_hw based APIs >> clk: imx: add imx7ulp clk driver >> >> .../devicetree/bindings/clock/imx7ulp-clock.txt | 87 +++++++++ >> drivers/clk/clk-divider.c | 152 +++++++++++++++ >> drivers/clk/clk-fractional-divider.c | 10 + >> drivers/clk/imx/Makefile | 6 +- >> drivers/clk/imx/clk-busy.c | 2 +- >> drivers/clk/imx/clk-composite.c | 85 +++++++++ >> drivers/clk/imx/clk-fixup-mux.c | 2 +- >> drivers/clk/imx/clk-imx7ulp.c | 209 >> +++++++++++++++++++++ >> drivers/clk/imx/clk-pfdv2.c | 201 >> ++++++++++++++++++++ >> drivers/clk/imx/clk-pllv4.c | 182 ++++++++++++++++++ >> drivers/clk/imx/clk.c | 22 +++ >> drivers/clk/imx/clk.h | 92 ++++++++- >> include/dt-bindings/clock/imx7ulp-clock.h | 109 +++++++++++ >> include/linux/clk-provider.h | 17 ++ >> 14 files changed, 1166 insertions(+), 10 deletions(-) create mode 100644 >> Documentation/devicetree/bindings/clock/imx7ulp-clock.txt >> create mode 100644 drivers/clk/imx/clk-composite.c create mode 100644 >> drivers/clk/imx/clk-imx7ulp.c create mode 100644 drivers/clk/imx/clk- >> pfdv2.c create mode 100644 drivers/clk/imx/clk-pllv4.c create mode 100644 >> include/dt-bindings/clock/imx7ulp-clock.h >> >> -- >> 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
