On Thu, Aug 9, 2018 at 2:03 PM, Steven Rostedt <rost...@goodmis.org> wrote: > From: "Steven Rostedt (VMware)" <rost...@goodmis.org> > > Joel Fernandes created a nice patch that cleaned up the duplicate hooks used > by lockdep and irqsoff latency tracer. It made both use tracepoints. But the > latency tracer is triggering warnings when using tracepoints to call into > the latency tracer's routines. Mainly, they can be called from NMI context. > If that happens, then the SRCU may not work properly because on some > architectures, SRCU is not safe to be called in both NMI and non-NMI > context. > > This is a partial revert of the clean up patch c3bc8fd637a9 ("tracing: > Centralize preemptirq tracepoints and unify their usage") that adds back the > direct calls into the latency tracer. It also only calls the trace events > when not in NMI. > > Cc: Joel Fernandes <joe...@google.com> > Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and unify > their usage") > Signed-off-by: Steven Rostedt (VMware) <rost...@goodmis.org>
Reviewed-by: Joel Fernandes (Google) <j...@joelfernandes.org> thanks, - Joel