From: kbuild test robot <fengguang...@intel.com> NULL check before some freeing functions is not needed.
Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 0099cc17a399 ("ASoC:topology:avoid error log and oops during topology free.") Signed-off-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- Feel free to ignore this if the null test is useful in some way. topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/sound/soc/sof/topology.c +++ b/sound/soc/sof/topology.c @@ -2165,8 +2165,7 @@ void snd_sof_free_topology(struct snd_so /* free sroute and its private data */ kfree(sroute->route->source); kfree(sroute->route->sink); - if (sroute->route->control) - kfree(sroute->route->control); + kfree(sroute->route->control); kfree(sroute->route); kfree(sroute->private); kfree(sroute);