Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.
On Tue, 14 Aug 2018 17:42:32 +0530, Sricharan R wrote:
> The kryo cpufreq driver reads the nvmem cell and uses that data to
> populate the opps. There are other qcom cpufreq socs like krait which
> does similar thing. Except for the interpretation of the read data,
> rest of the driver is same for both the cases. So pull the common things
> out for reuse.
>
> Signed-off-by: Sricharan R <sricha...@codeaurora.org>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../{kryo-cpufreq.txt => qcom-nvmem-cpufreq.txt} | 6 +-
> drivers/cpufreq/Kconfig.arm | 4 +-
> drivers/cpufreq/Makefile | 2 +-
> .../{qcom-cpufreq-kryo.c => qcom-cpufreq-nvmem.c} | 124
> ++++++++++++---------
> 4 files changed, 80 insertions(+), 56 deletions(-)
> rename Documentation/devicetree/bindings/opp/{kryo-cpufreq.txt =>
> qcom-nvmem-cpufreq.txt} (99%)
> rename drivers/cpufreq/{qcom-cpufreq-kryo.c => qcom-cpufreq-nvmem.c} (65%)
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
