On 2018-08-20 13:14, Caprioru, Mircea wrote:
> Ok now I understand. We can go with GPL-2.0-or-later and
> MODULE_LICENSE("GPL").
> We are pretty flexible regarding what license we should use upstream wise.
> If> you feel we should change it in some other way we can do that too.
Good, I'll just add your ack on the original patch. Both v2 and v2-or-later
are obviously fine and I don't care either way, I just didn't like the
discrepancy. The SPDX id is normally trumping the module-license tag so the
original patch feels like the lesser change. No need to stir the bowl...
Cheers,
Peter
>
> Regards,
> Mircea
>
> -----Original Message-----
> From: Peter Rosin [mailto:[email protected]]
> Sent: Monday, August 20, 2018 1:38 PM
> To: [email protected]
> Cc: Peter Rosin <[email protected]>; Caprioru, Mircea
> <[email protected]>
> Subject: [PATCH] mux: adgs1408: use the correct SPDX license identifier
>
> The file is GPL v2 only.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> drivers/mux/adgs1408.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> On 2018-08-20 12:16, Caprioru, Mircea wrote:
>> Peter Rosin wrote:
>>> I just noticed a discrepancy in the license annotations in your
>>> driver. The SPDX license identifier says GPL-2.0-or-later, and I
>>> assume that is correct and that MODULE_LICENSE("GPL") without the v2
>>> specifier, as in this patch, is the correct thing to do?
>>
>> The file should be v2. It might of slipped from the final version.
>
> Ok, so I read that as if it should be v2 *only* and not v2-or-later.
> I.e. the reverse of the original patch. But since these things can be
> sensitive, I'd like confirmation that this new patch is what is correct...
>
> Note that MODULE_LICENSE("GPL") means GPL v2 *or later* (GPL v1 is not on the
> table), while MODULE_LICENSE("GPL v2") means GPL v2 *only*.
> See include/linux/module.h for details.
>
> Cheers,
> Peter
>
> diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c index
> 0f7cf54e3234..fe0377bb83eb 100644
> --- a/drivers/mux/adgs1408.c
> +++ b/drivers/mux/adgs1408.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0-or-later
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * ADGS1408/ADGS1409 SPI MUX driver
> *
> --
> 2.11.0
>
>
