Hi Sergei, On Wed, 22 Aug 2018 12:34:30 +0300 <sergei.shtyl...@cogentembedded.com> wrote:
> Hello! > > On 8/22/2018 10:36 AM, Kunihiko Hayashi wrote: > > > Add support to get and control a list of resets for the device > > as optional and shared. These resets must be kept de-asserted until > > the device is enabled. > > > This is specified as shared because some SoCs like UniPhier series > > have common reset controls with all ahci controller instances. > > > However, according to Thierry's view, > > https://www.spinics.net/lists/linux-ide/msg55357.html > > some hardware-specific drivers already use their own resets, > > and the common reset make a path to occur double controls of resets. > > > Now this add the flag to ahci_platform_get_resources() indicating > > whether to use the resources, currently resets only, and existing > > drivers set 0 to this flags. > > > Suggested-by: Hans de Goede <hdego...@redhat.com> > > Cc: Thierry Reding <thierry.red...@gmail.com> > > Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com> > [...] > > > diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h > > index 1b0a17b..eaedca5f 100644 > > --- a/include/linux/ahci_platform.h > > +++ b/include/linux/ahci_platform.h > > @@ -30,7 +30,7 @@ void ahci_platform_disable_regulators(struct > > ahci_host_priv *hpriv); > > int ahci_platform_enable_resources(struct ahci_host_priv *hpriv); > > void ahci_platform_disable_resources(struct ahci_host_priv *hpriv); > > struct ahci_host_priv *ahci_platform_get_resources( > > - struct platform_device *pdev); > > + struct platform_device *pdev, unsigned int flags); > > That breaks all the users of this API. You should fix the callers in this > same patch to avoid breakage. Thank you for your point. Indeed, these splitted patches break git bisect. I'll fix it. --- Best Regards, Kunihiko Hayashi
