Quoting Christian Brauner ([email protected]): > bprm_caps_from_vfs_caps() never returned -EINVAL so remove the > rc == -EINVAL check. > > Signed-off-by: Christian Brauner <[email protected]>
Thanks. Reviewed-by: Serge Hallyn <[email protected]> > --- > v0 -> v1 > - non-functional changes: > adapt commit message to reflect the fact that > bprm_caps_from_vfs_caps() never actuall returned -EINVAL. > --- > security/commoncap.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/security/commoncap.c b/security/commoncap.c > index f4c33abd9959..6012f0cd8157 100644 > --- a/security/commoncap.c > +++ b/security/commoncap.c > @@ -684,9 +684,6 @@ static int get_file_caps(struct linux_binprm *bprm, bool > *effective, bool *has_f > } > > rc = bprm_caps_from_vfs_caps(&vcaps, bprm, effective, has_fcap); > - if (rc == -EINVAL) > - printk(KERN_NOTICE "%s: cap_from_disk returned %d for %s\n", > - __func__, rc, bprm->filename); > > out: > if (rc) > -- > 2.17.1
