On Mon, Aug 20, 2018 at 8:12 PM Janusz Krzysztofik <[email protected]> wrote:
> Don't request MODEM IRQ GPIO by its global number in > ams_delta_modem_init(). Instead, obtain its GPIO descriptor > and assign related IRQ to the MODEM. Do that from > omap_gpio_deps_init(), where the chip is already looked up. Then, in > ams_delta_modem_init(), just check for the IRQ number having been > already assigned. > > Signed-off-by: Janusz Krzysztofik <[email protected]> Reviewed-by: Linus Walleij <[email protected]> It's a bit unorthodox to have the board files intercept and poke around inside the gpio_chip like the code in this file does, I prefer to keep it encapsulated inside the GPIO driver. However this is the lesser evil... if OMAP1 is ever phased over to device tree it will go away, until then it is just nicely contained. Yours, Linus Walleij
