Hi Aaron, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc3 next-20180910] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Aaron-Tomlin/slub-extend-slub-debug-to-handle-multiple-slabs/20180911-030241 config: x86_64-randconfig-x008-201836 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from include/asm-generic/bug.h:18:0, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:9, from mm/slub.c:13: mm/slub.c: In function 'kmem_cache_flags': include/linux/kernel.h:845:29: warning: comparison of distinct pointer types lacks a cast (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ include/linux/kernel.h:859:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ include/linux/kernel.h:869:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ include/linux/kernel.h:885:19: note: in expansion of macro '__careful_cmp' #define max(x, y) __careful_cmp(x, y, >) ^~~~~~~~~~~~~ >> mm/slub.c:1306:13: note: in expansion of macro 'max' cmplen = max(len, end - n); ^~~ vim +/max +1306 mm/slub.c 1278 1279 slab_flags_t kmem_cache_flags(unsigned int object_size, 1280 slab_flags_t flags, const char *name, 1281 void (*ctor)(void *)) 1282 { 1283 /* 1284 * Enable debugging if selected on the kernel commandline. 1285 */ 1286 1287 char *end, *n, *glob; 1288 int len = strlen(name); 1289 1290 /* If slub_debug = 0, it folds into the if conditional. */ 1291 if (!slub_debug_slabs) 1292 return flags | slub_debug; 1293 1294 n = slub_debug_slabs; 1295 while (*n) { 1296 int cmplen; 1297 1298 end = strchr(n, ','); 1299 if (!end) 1300 end = n + strlen(n); 1301 1302 glob = strnchr(n, end - n, '*'); 1303 if (glob) 1304 cmplen = glob - n; 1305 else > 1306 cmplen = max(len, end - n); 1307 1308 if (!strncmp(name, n, cmplen)) { 1309 flags |= slub_debug; 1310 break; 1311 } 1312 1313 if (!*end) 1314 break; 1315 n = end + 1; 1316 } 1317 1318 return flags; 1319 } 1320 #else /* !CONFIG_SLUB_DEBUG */ 1321 static inline void setup_object_debug(struct kmem_cache *s, 1322 struct page *page, void *object) {} 1323 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
