On Wed, 29 Aug 2018, Matti Vaittinen wrote:
> Few regulators in BD71837 and BD71847 can output voltages from
> different voltage ranges. Register interface is arranged so that
> used range is selected by toggling bits which are not next to actual
> voltage selection bits. Then the voltage inside selected range is
> determined by voltage selection bits (as usual). Support BD71837
> and BD71847 selectible range voltages using new pickable ranges
> helpers.
>
> Signed-off-by: Matti Vaittinen <[email protected]>
> ---
> drivers/regulator/bd71837-regulator.c | 155
> +++++++++++++++++++++++++++-------
> include/linux/mfd/rohm-bd718x7.h | 38 +++++----
> 2 files changed, 147 insertions(+), 46 deletions(-)
[...]
> diff --git a/include/linux/mfd/rohm-bd718x7.h
> b/include/linux/mfd/rohm-bd718x7.h
> index d1730b97ba52..4cc617047d5f 100644
> --- a/include/linux/mfd/rohm-bd718x7.h
> +++ b/include/linux/mfd/rohm-bd718x7.h
> @@ -7,13 +7,13 @@
> #include <linux/regmap.h>
>
> enum {
> - BD718XX_TYPE_BD71837,
> + BD718XX_TYPE_BD71837 = 0,
> BD718XX_TYPE_BD71847,
> BD718XX_TYPE_AMNT // Keep this as last item
> };
>
> enum {
> - BD718XX_BUCK1 = 0,
> + BD718XX_BUCK1 = 0,
> BD718XX_BUCK2,
> BD718XX_BUCK3,
> BD718XX_BUCK4,
> @@ -31,31 +31,27 @@ enum {
> BD718XX_REGULATOR_MAX,
> };
Even though I don't care enough to NACK the patch, the above are
unrelated changes and should normally be contained in a separate
patch.
For my own reference:
Acked-for-MFD-by: Lee Jones <[email protected]>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
