Hi, [ Cc:'s trimmed ]
On 7/2/07, Josef Sipek <[EMAIL PROTECTED]> wrote:
On Sun, Jul 01, 2007 at 10:23:30PM +0200, Adrian Bunk wrote: > This patch makes some needlessly global functions static. > ... > --- linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c.old 2007-07-01 00:05:02.000000000 +0200 > +++ linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c 2007-07-01 00:06:05.000000000 +0200 > @@ -18,6 +18,8 @@ > > #include "union.h" > > +static int realloc_dentry_private_data(struct dentry *dentry); > + > /* is the filename valid == !(whiteout for a file or opaque dir marker) */ I forget who said it, but someone wasn't very happy with prototypes like that in .c files. What's the prefered way - are they ok for static symbols?
The preferred way is to push static functions' definitions above the callsites (caller functions) in the same file, if possible. Perhaps Adrian was in a hurry so didn't do that ... Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
