RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

[Naga Sureshkumar Relli]

Hi Boris & Miquel,

> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> Sent: Saturday, September 22, 2018 1:43 PM
> To: Miquel Raynal <miquel.ray...@bootlin.com>
> Cc: Naga Sureshkumar Relli <nagas...@xilinx.com>; rich...@nod.at; 
> dw...@infradead.org;
> computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com;
> abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; 
> linux-
> m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek 
> <mich...@xilinx.com>;
> nagasureshkumarre...@gmail.com
> Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for 
> Arasan NAND
> Flash Controller
> 
> On Sat, 22 Sep 2018 09:53:40 +0200
> Miquel Raynal <miquel.ray...@bootlin.com> wrote:
> 
> > Hi Naga,
> >
> > Naga Sureshkumar Relli <nagas...@xilinx.com> wrote on Tue, 11 Sep 2018
> > 05:23:09 +0000:
> >
> > > Hi Boris,
> > >
> > > > -----Original Message-----
> > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > > > Sent: Monday, August 20, 2018 10:10 PM
> > > > To: Naga Sureshkumar Relli <nagas...@xilinx.com>
> > > > Cc: miquel.ray...@bootlin.com; rich...@nod.at;
> > > > dw...@infradead.org; computersforpe...@gmail.com;
> > > > marek.va...@gmail.com; kyungmin.p...@samsung.com;
> > > > abs...@codeaurora.org; peterpand...@micron.com;
> > > > frieder.schre...@exceet.de; linux- m...@lists.infradead.org;
> > > > linux-kernel@vger.kernel.org; Michal Simek <mich...@xilinx.com>;
> > > > nagasureshkumarre...@gmail.com
> > > > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add
> > > > support for Arasan NAND Flash Controller
> > > >
> > > > Hi Naga,
> > > >
> > > > On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli
> > > > <naga.sureshkumar.re...@xilinx.com> wrote:
> > > >
> > > >
> > > > I haven't finished reviewing the driver but there are still a
> > > > bunch of things that look strange, for instance, your
> > > > ->read/write_page() implementation looks suspicious. Let's discuss that 
> > > > before you send a
> new version.
> 
> Sorry, I've been too busy to finish my review :-/. Please submit the new 
> version as Miquel
> suggested.
Ok, I will do.

Thanks,
Naga Sureshkumar Relli
> 
> > > Could you please review the remaining stuff?
> > > I have the changes ready with me which will address all your comments 
> > > given to this series.
> > >
> > > Thanks,
> > > Naga Sureshkumar Relli
> >
> > Please submit the new version that is ready, the rest of the review
> > will come.
> >
> >
> > Thanks,
> > Miquèl