On Wed, Sep 26, 2018 at 2:09 PM Andy Shevchenko <[email protected]> wrote: > > On Fri, Sep 21, 2018 at 9:20 AM Peter Feuerer <[email protected]> wrote: > > > > Hi, > > > > 21. September 2018 03:45, "Paul Gortmaker" <[email protected]> > > schrieb: > > > > > I came across this older netbook over the xmas holidays, and noticed the > > > acerhdf driver wouldn't load. Turns out the BIOS string was too new, > > > and not listed in the driver. There were module params for overrides, > > > but I found their use isn't quite clear without reading the source. > > > > > > Here I clarify some of the module parameter usage, and then add the new > > > BIOS string, so they won't be needed for this particular platform. Some > > > probe code is also shifted out to be __init to reduce the driver size a > > > bit. Further details can be found in the respective commit logs. > > > > > > Since it was months ago when I created these patches, I retested on top > > > of tree to ensure things still work, as can be seen below. > > > > Thanks a lot for your work and this set of changes. This improves quality. > > I reviewed all 6 patches. > > > > Reviewed-by: Peter Feuerer <[email protected]> > > > > Please also add CC: Boris Petkov <[email protected]> for review. > > Shall I wait for Boris' tags?
Anyway, all suggested changes look good to me, I go ahead and push them to my review and testing queue. If nothing happens during let's say a week, I will move them forward. Thanks! -- With Best Regards, Andy Shevchenko
