On Mon, Oct 01, 2018 at 11:46:57AM -0700, Stephen Boyd wrote:
> Quoting Niklas Cassel (2018-09-12 03:34:31)
> > Hello Stephen,
> >
> > I'm getting this warning on dragonboard 820c (msm8996) when booting
> > linux-next:
> >
> > [ 3.211575] WARNING: CPU: 1 PID: 1 at
> > drivers/pinctrl/qcom/pinctrl-msm.c:164 msm_pinmux_set_mux+0xc8/0x150
> > [ 3.212127] l28: ramp_delay not set
>
> Thanks for testing. I think the problem is I messed up the function 0
> and enum 0. Can you try this patch?
Hello Stephen,
This patch does indeed remove the warning.
Thanks!
Kind regards,
Niklas
>
> --8<---
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c
> b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 1684b2da09d5..b925b8feac95 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -188,7 +188,7 @@ static int msm_pinmux_request_gpio(struct pinctrl_dev
> *pctldev,
> return 0;
>
> /* For now assume function 0 is GPIO because it always is */
> - return msm_pinmux_set_mux(pctldev, 0, offset);
> + return msm_pinmux_set_mux(pctldev, g->funcs[0], offset);
> }
>
> static const struct pinmux_ops msm_pinmux_ops = {
