4.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Jean-Christophe Dubois <[email protected]>

[ Upstream commit be926ceeb4efc3bf44cb9b56f5c71aac9b1f8bbe ]

Without this fix, the thermal probe on i.MX6 might trigger a division
by zero exception later in the probe if the calibration does fail.

Note: This linux behavior (Division by zero in kernel) has been triggered
on a Qemu i.MX6 emulation where parameters in nvmem were not set. With this
fix the division by zero is not triggeed anymore as the thermal probe does
fail early.

Signed-off-by: Jean-Christophe Dubois <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Eduardo Valentin <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 drivers/thermal/imx_thermal.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -604,7 +604,10 @@ static int imx_init_from_nvmem_cells(str
        ret = nvmem_cell_read_u32(&pdev->dev, "calib", &val);
        if (ret)
                return ret;
-       imx_init_calib(pdev, val);
+
+       ret = imx_init_calib(pdev, val);
+       if (ret)
+               return ret;
 
        ret = nvmem_cell_read_u32(&pdev->dev, "temp_grade", &val);
        if (ret)


Reply via email to