* Tim Chen <[email protected]> wrote:

> Thanks for the corrections.  I'll update the patchset.

Please also go beyond the direct review feedback me and Thomas gave, and 
pro-actively look out 
for similar patterns of mistakes in these patches and in all future patches you 
send.

As Thomas's and my review made it abundantly clear, this patch series has a 
very high 
proportion of small, indefensible trivial quality problems.

If the root of the problem is that you are sending out patches too fast then 
please *read* your 
own code and changelogs more than once before sending it to lkml, fix trivial 
mistakes and 
coding style so that others don't have to waste time over trivialities.

If the root of the problem is that you don't have enough time to spend on these 
patches then 
you should perhaps delay your next series for another day or two, use more time 
to review the 
series, before sending it for an upstream merge.

I.e. please make a serious effort to improve patch and changelog quality in the 
future.

Thanks,

        Ingo

Reply via email to