Hi Emil, On Wed, Oct 3, 2018 at 11:43 AM Emil Karlson <[email protected]> wrote: > > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events > be truncated on many chromebooks so that Left and Right keys on Column 12 were > always 0. Use ret as memcpy len to fix this. > > The old code was using ec_dev->event_size, which is the event payload/data > size > excluding event_type header, for the length of the memcpy operation. Use ret > as memcpy length to avoid the off by one and copy the whole msg->data. > > Fixes: 57e94c8b974d ("mfd: cros-ec: Increase maximum mkbp event size") > > Acked-by: Enric Balletbo i Serra <[email protected]> > Tested-by: Emil Renner Berthing <[email protected]> > Signed-off-by: Emil Karlson <[email protected]>
Applied. Sent to Greg for rc8, hopefully. -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]
