There are a number of places in the sr8900 driver where it gets the
private-data from the usbnet passed in. It would be sensible to have
one inline function to convert it and change all points in the driver
to use that.

Signed-off-by: Ben Dooks <[email protected]>
---
 drivers/net/usb/sr9800.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
index 9277a0f228df..2093ecfff5a5 100644
--- a/drivers/net/usb/sr9800.c
+++ b/drivers/net/usb/sr9800.c
@@ -25,6 +25,11 @@
 
 #include "sr9800.h"
 
+static inline struct sr_data *usbnet_to_sr(struct usbnet *usb)
+{
+       return (struct sr_data *)&usb->data;
+}
+
 static int sr_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
                            u16 size, void *data)
 {
@@ -296,7 +301,7 @@ static int sr_write_gpio(struct usbnet *dev, u16 value, int 
sleep)
 static void sr_set_multicast(struct net_device *net)
 {
        struct usbnet *dev = netdev_priv(net);
-       struct sr_data *data = (struct sr_data *)&dev->data;
+       struct sr_data *data = usbnet_to_sr(dev);
        u16 rx_ctl = SR_DEFAULT_RX_CTL;
 
        if (net->flags & IFF_PROMISC) {
@@ -436,7 +441,7 @@ sr_set_wol(struct net_device *net, struct ethtool_wolinfo 
*wolinfo)
 static int sr_get_eeprom_len(struct net_device *net)
 {
        struct usbnet *dev = netdev_priv(net);
-       struct sr_data *data = (struct sr_data *)&dev->data;
+       struct sr_data *data = usbnet_to_sr(dev);
 
        return data->eeprom_len;
 }
@@ -493,7 +498,7 @@ static int sr_ioctl(struct net_device *net, struct ifreq 
*rq, int cmd)
 static int sr_set_mac_address(struct net_device *net, void *p)
 {
        struct usbnet *dev = netdev_priv(net);
-       struct sr_data *data = (struct sr_data *)&dev->data;
+       struct sr_data *data = usbnet_to_sr(dev);
        struct sockaddr *addr = p;
 
        if (netif_running(net))
@@ -595,7 +600,7 @@ static int sr9800_set_default_mode(struct usbnet *dev)
 
 static int sr9800_reset(struct usbnet *dev)
 {
-       struct sr_data *data = (struct sr_data *)&dev->data;
+       struct sr_data *data = usbnet_to_sr(dev);
        int ret, embd_phy;
        u16 rx_ctl;
 
@@ -726,7 +731,7 @@ static int sr9800_phy_powerup(struct usbnet *dev)
 
 static int sr9800_bind(struct usbnet *dev, struct usb_interface *intf)
 {
-       struct sr_data *data = (struct sr_data *)&dev->data;
+       struct sr_data *data = usbnet_to_sr(dev);
        u16 led01_mux, led23_mux;
        int ret, embd_phy;
        u32 phyid;
-- 
2.19.1

Reply via email to