On Tue, Oct 16, 2018 at 5:01 AM Guo Ren <[email protected]> wrote: > > This patch adds files related to syscall. > > Signed-off-by: Guo Ren <[email protected]> > Cc: Arnd Bergmann <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]> I had a detailed look at this one and provided lots of comments, however one tiny thing escaped me: > +#define __NR_set_thread_area (__NR_arch_specific_syscall + 0) > +__SYSCALL(__NR_set_thread_area, sys_set_thread_area) > +#define __NR_cacheflush (__NR_arch_specific_syscall + 4) > +__SYSCALL(__NR_cacheflush, sys_cacheflush) It's odd that the second one uses __NR_arch_specific_syscall + 4 rather than +1. If you can still change that changing too much other stuff, that might avoid some head-scratching later. If it causes problems, just leave it and maybe add a comment saying that the numbers inbetween are still available. Arnd
