On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel <lkund...@v3.sk> wrote: > > Just return ENODEV, so that whoever attempted to use the EC call can > defer their work. > > Signed-off-by: Lubomir Rintel <lkund...@v3.sk> > --- > drivers/platform/olpc/olpc-ec.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c > index 35a21c66cd0d..342f5bb7f7a8 100644 > --- a/drivers/platform/olpc/olpc-ec.c > +++ b/drivers/platform/olpc/olpc-ec.c > @@ -116,8 +116,11 @@ int olpc_ec_cmd(u8 cmd, u8 *inbuf, size_t inlen, u8 > *outbuf, size_t outlen) > struct olpc_ec_priv *ec = ec_priv; > struct ec_cmd_desc desc; > > - /* Ensure a driver and ec hook have been registered */ > - if (WARN_ON(!ec_driver || !ec_driver->ec_cmd)) > + /* Driver not yet registered. */ > + if (!ec_driver) > + return -ENODEV;
Why -ENODEV is preferred over -EPROBE_DEFER? > + > + if (WARN_ON(!ec_driver->ec_cmd)) > return -ENODEV; > > if (!ec) > -- > 2.19.0 > -- With Best Regards, Andy Shevchenko
