On Wed, Oct 17, 2018 at 9:24 PM Bartlomiej Zolnierkiewicz <[email protected]> wrote: > > Enable+check sensor after setting tmdev->sensor[i].tzd and calling > chipset specific enable operation. > > Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]> > --- > drivers/thermal/qcom/tsens.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index dbd2556..01bff96 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -105,13 +105,13 @@ static int tsens_register(struct tsens_device *tmdev) > if (IS_ERR(tzd)) > continue; > > - thermal_zone_set_mode(tzd, THERMAL_DEVICE_ENABLED); > - thermal_zone_device_check(tzd); > -
I don't quite understand why you're making this move explicitly in a separate patch for each of the drivers? You added it here in patch 4 in the first place, why not add it in the correct place there itself? > tmdev->sensor[i].tzd = tzd; > > if (tmdev->ops->enable) > tmdev->ops->enable(tmdev, i); > + > + thermal_zone_set_mode(tzd, THERMAL_DEVICE_ENABLED); > + thermal_zone_device_check(tzd); > > } > return 0; > } > -- > 1.9.1 >
