Commit-ID: 3424243e39e8ec138486926949e3668e7553125d
Gitweb: https://git.kernel.org/tip/3424243e39e8ec138486926949e3668e7553125d
Author: Dan Carpenter <dan.carpen...@oracle.com>
AuthorDate: Sat, 13 Oct 2018 13:22:46 +0300
Committer: Thomas Gleixner <t...@linutronix.de>
CommitDate: Thu, 1 Nov 2018 12:38:48 +0100
irqchip/irq-mvebu-sei: Fix a NULL vs IS_ERR() bug in probe function
The devm_ioremap_resource() function never returns NULL, it returns
error pointers.
Fixes: 61ce8d8d8a81 ("irqchip/irq-mvebu-sei: Add new driver for Marvell SEI")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Reviewed-by: Miquel Raynal <miquel.ray...@bootlin.com>
Cc: Jason Cooper <ja...@lakedaemon.net>
Cc: Andrew Lunn <and...@lunn.ch>
Cc: Gregory Clement <gregory.clem...@bootlin.com>
Cc: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com>
Cc: Marc Zyngier <marc.zyng...@arm.com>
Cc: linux-arm-ker...@lists.infradead.org
Cc: kernel-janit...@vger.kernel.org
Link: https://lkml.kernel.org/r/20181013102246.GD16086@mwanda
---
drivers/irqchip/irq-mvebu-sei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-sei.c
index 566d69a2edbc..add4c9c934c8 100644
--- a/drivers/irqchip/irq-mvebu-sei.c
+++ b/drivers/irqchip/irq-mvebu-sei.c
@@ -384,9 +384,9 @@ static int mvebu_sei_probe(struct platform_device *pdev)
sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sei->base = devm_ioremap_resource(sei->dev, sei->res);
- if (!sei->base) {
+ if (IS_ERR(sei->base)) {
dev_err(sei->dev, "Failed to remap SEI resource\n");
- return -ENODEV;
+ return PTR_ERR(sei->base);
}
/* Retrieve the SEI capabilities with the interrupt ranges */
