On Fri, Nov 2, 2018 at 9:46 AM Joakim Tjernlund <joakim.tjernl...@infinera.com> wrote: > > On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. > > > > > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by config options. > > > > It defaults to native-endian (the previously hard-coded option). > > > > Some architectures benefit from having a single known endianness > > of JFFS2 filesystem (for data, not executables) independent of the > > endianness of the processor (ARM processors can be switched to either > > endianness at run-time). > > I like this too. I have on several occasions needed to mount a JFFS2 BE on > my PC. This saves me from having to hack the src.
The feature makes sense, but I don't like it being a Kconfig option. As Al pointed out, it should be done like UFS does. IOW, implement a wrapper function which selects the endianness automatically. That way you can force it as mount option or detect during mount what kind of JFFS2 you have. -- Thanks, //richard
