On Tue, Oct 30, 2018 at 10:14:30PM +0000, Jonathan McDowell wrote:
> +     r_gpio_keys {
> +             compatible = "gpio-keys";
> +             pinctrl-names = "default";
> +
> +             power {
> +                     label = "mp130:power";

That was my mistake, but it was correct in your first version.

> +&pio {
> +     leds_pio: led_pins {
> +             pins = "PA15";
> +             function = "gpio_out";
> +     };
> +};
> +
> +&r_pio {
> +     leds_r_pio: led_pins {
> +             pins = "PL10";
> +             function = "gpio_out";
> +     };
> +
> +     sw_r_pio: key_pins {
> +             pins = "PL3", "PL4";
> +             function = "gpio_in";
> +     };
> +};

You don't need these nodes at all.

I've fixed both issues and applied your patch for 4.21

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature

Reply via email to