On Mon, Nov 05, 2018 at 12:17:23PM +0300, Heikki Krogerus wrote: > Hi, > > I prepared fwnode_name() for something I'm working on, but then I > realized that it makes it possible to also implement a generic > fwnode_get_named_child_node(). So in practice I'm proposing that we > replace get_named_child_node fwnode op with that new "name" fwnode op > in this series. >
All LGTM, though consider one minor comment in patch 1. Reviewed-by: Andy Shevchenko <[email protected]> > thanks, > > Heikki Krogerus (4): > device property: Introduce fwnode_name() > ACPI: property: Introduce acpi_fwnode_name() > of/property: Introduce of_fwnode_name() > device property: Drop get_named_child_node callback > > drivers/acpi/property.c | 26 +++++++------------------- > drivers/base/property.c | 28 +++++++++++++++++++++++++++- > drivers/of/property.c | 21 ++++++--------------- > include/linux/fwnode.h | 4 +--- > include/linux/property.h | 2 ++ > 5 files changed, 43 insertions(+), 38 deletions(-) > > -- > 2.19.1 > -- With Best Regards, Andy Shevchenko
