On Tue, Nov 06, 2018 at 04:33:26PM +0000, David Binderman wrote: > hello there Russell, > > > linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576]: (warning) Redundant > > assignment of >'ufp_exc->fpinst2' to itself. > > >Thanks for the report - it most certainly is a bug introduced by > >Julien's patches, but I don't get your warning here. Which compiler > >produces that warning? > > Not a compiler, cppcheck, a static analyser for C and C++ code. > > Interestingly, more of the same in file > linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c > > [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:84]: (warning) Redundant > assignment of 'ASCR' to itself. > [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:85]: (warning) Redundant > assignment of 'ARSR' to itself. > [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:120]: (warning) Redundant > assignment of 'ASCR' to itself. > [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:121]: (warning) Redundant > assignment of 'ARSR' to itself. > > I don't know if these four are also worth fixing.
There are cases where this can be false positives. In the case of a status register with write-1-to-clear bits for example. These ones look very much like that. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
