Hi Mark, On Tue, Nov 6, 2018 at 6:52 PM Mark Brown <[email protected]> wrote: > Most architectures provide prototypes for the PCI I/O mapping operations > when asm/io.h is included but SH doesn't currently do that, leading to > for example warnings in sound/pci/hda/patch_ca0132.c when pci_iomap() is > used on current -next. Make SH more consistent with other architectures
Also on v4.20-rc1, cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/13576888/ > by including asm-generic/pci_iomap.h in asm/io.h. > > Reported-by: kbuild test robot <[email protected]> > Signed-off-by: Mark Brown <[email protected]> Thanks for your patch! > --- a/arch/sh/include/asm/io.h > +++ b/arch/sh/include/asm/io.h > @@ -24,6 +24,7 @@ > #define __IO_PREFIX generic > #include <asm/io_generic.h> > #include <asm/io_trapped.h> > +#include <asm-generic/pci_iomap.h> Is this sufficient? include/asm-generic/pci_iomap.h provides the dummies if CONFIG_PCI=n and CONFIG_GENERIC_PCI_IOMAP=y, while arch/sh/Kconfig selects GENERIC_PCI_IOMAP only if PCI is enabled. Hence it's not set in the failing config (sh/allyesconfig). Probably SH should select GENERIC_PCI_IOMAP unconditionally, like most other architectures do (alpha and powerpc select it conditionally, though)? > #include <mach/mangle-port.h> > > #define __raw_writeb(v,a) (__chk_io_ptr(a), *(volatile u8 __force > *)(a) = (v)) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
