Hi Claudiu, On 05/11/2018 11:14:26+0000, claudiu.bez...@microchip.com wrote: > static int __init at91_poweroff_probe(struct platform_device *pdev) > @@ -154,16 +160,22 @@ static int __init at91_poweroff_probe(struct > platform_device *pdev) > u32 ddr_type; > int ret; > > + at91_shdwc = devm_kzalloc(&pdev->dev, sizeof(*at91_shdwc), GFP_KERNEL); > + if (!at91_shdwc) > + return -ENOMEM; > +
Is there any real benefit that will offset the time lost for that allocation at boot time? I understand you are then testing at91_shdwc to know whether the driver already probed once. But, the driver will never probe twice as there is only one shutdown controller on the SoC and anyway, If it was to probe twice, it will still work as expected. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com