Re: [PATCH v5 08/17] tpm: access command header through struct in tpm_try_transmit()

[Stefan Berger]

On 11/8/18 9:15 AM, Jarkko Sakkinen wrote:

Instead of accessing fields of the command header through offsets to
the raw buffer, it is a better idea to use the header struct pointer
that is already used elsewhere in the function.

Signed-off-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>

Reviewed-by: Stefan Berger <stef...@linux.ibm.com>

---
  drivers/char/tpm/tpm-interface.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index 6abbcedc87a3..f2280bf15339 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -190,8 +190,8 @@ static ssize_t tpm_try_transmit(struct tpm_chip *chip,
        if (bufsiz > TPM_BUFSIZE)
                bufsiz = TPM_BUFSIZE;

-       count = be32_to_cpu(*((__be32 *) (buf + 2)));
-       ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
+       count = be32_to_cpu(header->length);
+       ordinal = be32_to_cpu(header->ordinal);
        if (count == 0)
                return -ENODATA;
        if (count > bufsiz) {