From: Lance Roy <ldr...@gmail.com>

lockdep_assert_held() is better suited to checking locking requirements,
since it only checks if the current thread holds the lock regardless of
whether someone else does. This is also a step towards possibly removing
spin_is_locked().

Signed-off-by: Lance Roy <ldr...@gmail.com>
Cc: Steve Glendinning <steve.glendinn...@shawell.net>
Cc: "David S. Miller" <da...@davemloft.net>
Cc: <net...@vger.kernel.org>
Signed-off-by: Paul E. McKenney <paul...@linux.ibm.com>
---
 drivers/net/ethernet/smsc/smsc911x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.h 
b/drivers/net/ethernet/smsc/smsc911x.h
index 8d75508acd2b..51b2fc1a395f 100644
--- a/drivers/net/ethernet/smsc/smsc911x.h
+++ b/drivers/net/ethernet/smsc/smsc911x.h
@@ -67,7 +67,7 @@
 
 #ifdef CONFIG_DEBUG_SPINLOCK
 #define SMSC_ASSERT_MAC_LOCK(pdata) \
-               WARN_ON_SMP(!spin_is_locked(&pdata->mac_lock))
+               lockdep_assert_held(&pdata->mac_lock)
 #else
 #define SMSC_ASSERT_MAC_LOCK(pdata) do {} while (0)
 #endif                         /* CONFIG_DEBUG_SPINLOCK */
-- 
2.17.1

Reply via email to